Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1053123007: Invalidate paint of tickmarks on document change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override; 333 virtual void willRemoveScrollbar(Scrollbar*, ScrollbarOrientation) override;
334 334
335 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter 335 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
336 // passed around the FrameView layout methods can be true while this returns 336 // passed around the FrameView layout methods can be true while this returns
337 // false. 337 // false.
338 bool isSubtreeLayout() const { return !m_layoutSubtreeRoots.isEmpty(); } 338 bool isSubtreeLayout() const { return !m_layoutSubtreeRoots.isEmpty(); }
339 339
340 // Sets the tickmarks for the FrameView, overriding the default behavior 340 // Sets the tickmarks for the FrameView, overriding the default behavior
341 // which is to display the tickmarks corresponding to find results. 341 // which is to display the tickmarks corresponding to find results.
342 // If |m_tickmarks| is empty, the default behavior is restored. 342 // If |m_tickmarks| is empty, the default behavior is restored.
343 void setTickmarks(const Vector<IntRect>& tickmarks) { m_tickmarks = tickmark s; } 343 void setTickmarks(const Vector<IntRect>& tickmarks)
344 {
345 m_tickmarks = tickmarks;
346 invalidatePaintOfTickmarks();
347 }
348
349 void invalidatePaintOfTickmarks() const;
chrishtr 2015/04/17 23:21:42 invalidatePaintForTickmarks
Xianzhu 2015/04/18 02:13:48 Done.
344 350
345 // Since the compositor can resize the viewport due to top controls and 351 // Since the compositor can resize the viewport due to top controls and
346 // commit scroll offsets before a WebView::resize occurs, we need to adjust 352 // commit scroll offsets before a WebView::resize occurs, we need to adjust
347 // our scroll extents to prevent clamping the scroll offsets. 353 // our scroll extents to prevent clamping the scroll offsets.
348 void setTopControlsViewportAdjustment(float); 354 void setTopControlsViewportAdjustment(float);
349 355
350 virtual IntPoint maximumScrollPosition() const override; 356 virtual IntPoint maximumScrollPosition() const override;
351 357
352 // ScrollableArea interface 358 // ScrollableArea interface
353 virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&) override; 359 virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&) override;
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 static const unsigned visualPixelThreshold = 32 * 32; 879 static const unsigned visualPixelThreshold = 32 * 32;
874 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 880 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
875 setIsVisuallyNonEmpty(); 881 setIsVisuallyNonEmpty();
876 } 882 }
877 883
878 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 884 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
879 885
880 } // namespace blink 886 } // namespace blink
881 887
882 #endif // FrameView_h 888 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698