Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: src/compiler/code-generator.cc

Issue 1053123006: Calculate blocks needing a frame and frame (de)construction sites. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Added missing files Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/compiler/frame-elider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index dd6565c17b58dba25cd3c7cedb9e48d065ee8ffa..13087ec0aa1f76a4473fe11c5366eaceaae1851f 100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -84,8 +84,12 @@ Handle<Code> CodeGenerator::GenerateCode() {
current_block_ = block->rpo_number();
if (FLAG_code_comments) {
// TODO(titzer): these code comments are a giant memory leak.
- Vector<char> buffer = Vector<char>::New(32);
- SNPrintF(buffer, "-- B%d start --", block->rpo_number().ToInt());
+ Vector<char> buffer = Vector<char>::New(200);
+ SNPrintF(buffer, "-- B%d start%s%s%s%s --", block->rpo_number().ToInt(),
+ block->IsDeferred() ? " (deferred)" : "",
+ block->needs_frame() ? "" : " (no frame)",
+ block->must_construct_frame() ? " (construct frame)" : "",
+ block->must_deconstruct_frame() ? " (deconstruct frame)" : "");
masm()->RecordComment(buffer.start());
}
masm()->bind(GetLabel(current_block_));
« no previous file with comments | « BUILD.gn ('k') | src/compiler/frame-elider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698