Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: google_apis/drive/base_requests.h

Issue 1053123004: Drive: Add BatchableRequest subclass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/drive/base_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/base_requests.h
diff --git a/google_apis/drive/base_requests.h b/google_apis/drive/base_requests.h
index 9c66fe6becf761d8926bf70bb414b77860a5171c..a95d234d74f79e27a8cd9b64226228ab801e010b 100644
--- a/google_apis/drive/base_requests.h
+++ b/google_apis/drive/base_requests.h
@@ -258,6 +258,27 @@ class UrlFetchRequestBase : public AuthenticatedRequestInterface,
DISALLOW_COPY_AND_ASSIGN(UrlFetchRequestBase);
};
+//============================ BatchableRequestBase ============================
+
+class BatchableRequestBase : public UrlFetchRequestBase {
+ public:
+ explicit BatchableRequestBase(RequestSender* sender) :
+ UrlFetchRequestBase(sender) {}
+
+ GURL GetURL() const override = 0;
+ net::URLFetcher::RequestType GetRequestType() const override;
+ std::vector<std::string> GetExtraRequestHeaders() const override;
+ void Prepare(const PrepareCallback& callback) override;
+ bool GetContentData(std::string* upload_content_type,
+ std::string* upload_content) override;
+ void RunCallbackOnPrematureFailure(DriveApiErrorCode code) override = 0;
+ virtual void ProcessURLFetchResults(
+ DriveApiErrorCode code, const std::string& body) = 0;
+
+ private:
+ void ProcessURLFetchResults(const net::URLFetcher* source) final;
+};
+
//============================ EntryActionRequest ============================
// Callback type for requests that return only error status, like: Delete/Move.
@@ -475,7 +496,7 @@ class GetUploadStatusRequestBase : public UploadRangeRequestBase {
// This class provides base implementation for performing the request for
// uploading a file by multipart body.
-class MultipartUploadRequestBase : public UrlFetchRequestBase {
+class MultipartUploadRequestBase : public BatchableRequestBase {
public:
// Set boundary. Only tests can use this method.
void SetBoundaryForTesting(const std::string& boundary);
@@ -498,7 +519,8 @@ class MultipartUploadRequestBase : public UrlFetchRequestBase {
void Prepare(const PrepareCallback& callback) override;
bool GetContentData(std::string* upload_content_type,
std::string* upload_content) override;
- void ProcessURLFetchResults(const net::URLFetcher* source) override;
+ void ProcessURLFetchResults(
+ DriveApiErrorCode code, const std::string& body) override;
void RunCallbackOnPrematureFailure(DriveApiErrorCode code) override;
// content::UrlFetcherDelegate overrides.
« no previous file with comments | « no previous file | google_apis/drive/base_requests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698