Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1053123004: Drive: Add BatchableRequest subclass. (Closed)

Created:
5 years, 8 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drive: Add BatchableRequest subclass. To generate batch request from each request instance, batachable request class must publish several methods to BatchRequestClass. BUG=451917 TEST=None Committed: https://crrev.com/900d55c855dc055f82bc3db1cb313b3e8ae1781b Cr-Commit-Position: refs/heads/master@{#324197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M google_apis/drive/base_requests.h View 3 chunks +24 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests.cc View 3 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 8 months ago (2015-04-03 09:36:12 UTC) #2
kinaba
lgtm
5 years, 8 months ago (2015-04-08 00:22:14 UTC) #3
hirono
On 2015/04/08 00:22:14, kinaba wrote: > lgtm Thank you!
5 years, 8 months ago (2015-04-08 04:38:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053123004/1
5 years, 8 months ago (2015-04-08 04:39:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 08:01:49 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 08:02:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/900d55c855dc055f82bc3db1cb313b3e8ae1781b
Cr-Commit-Position: refs/heads/master@{#324197}

Powered by Google App Engine
This is Rietveld 408576698