Issue 1053083003: Fix GN build after r323361 (two changes collided).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1053083003: Fix GN build after r323361 (two changes collided). (Closed)

Created:
5 years, 8 months ago by jam

Modified:
5 years, 8 months ago

Reviewers:
sunnyps

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix GN build after r323361 (two changes collided). R=sunnyps@chromium.org Committed: https://crrev.com/b3fd5d76620a1af360c735cb4822ea541a8c4c8d Cr-Commit-Position: refs/heads/master@{#323558}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	mojo/services/surfaces/surfaces_scheduler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	mojo/services/surfaces/surfaces_scheduler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jam

Committed patchset #1 (id:1) manually as b3fd5d76620a1af360c735cb4822ea541a8c4c8d (presubmit successful).

5 years, 8 months ago (2015-04-02 21:06:31 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 20:28:54 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b3fd5d76620a1af360c735cb4822ea541a8c4c8d
Cr-Commit-Position: refs/heads/master@{#323558}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages