Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052993014: Dart: Adds mojom pub package. (Closed)

Created:
5 years, 8 months ago by zra
Modified:
5 years, 4 months ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, ppi+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Adds mojom pub package. Creates init.dart script that installs generated .mojom.dart files into the mojom pub package.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -1 line) Patch
A mojo/dart/mojom/AUTHORS View 1 chunk +9 lines, -0 lines 0 comments Download
A mojo/dart/mojom/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/dart/mojom/LICENSE View 1 chunk +1 line, -1 line 0 comments Download
A mojo/dart/mojom/PATENTS View 1 chunk +23 lines, -0 lines 0 comments Download
A mojo/dart/mojom/README.md View 1 chunk +11 lines, -0 lines 1 comment Download
A mojo/dart/mojom/bin/init.dart View 1 chunk +107 lines, -0 lines 0 comments Download
A mojo/dart/mojom/pubspec.lock View 1 chunk +11 lines, -0 lines 0 comments Download
A mojo/dart/mojom/pubspec.yaml View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/tools/deploy_sdk.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
I think we want the mojom package to be developed and maintained out of the ...
5 years, 8 months ago (2015-04-24 23:19:31 UTC) #2
Ivan Posva
I am not particularly fond of the name init. How about generate or something similar? ...
5 years, 8 months ago (2015-04-24 23:27:34 UTC) #3
Ivan Posva
https://codereview.chromium.org/1052993014/diff/1/mojo/dart/mojom/README.md File mojo/dart/mojom/README.md (right): https://codereview.chromium.org/1052993014/diff/1/mojo/dart/mojom/README.md#newcode10 mojo/dart/mojom/README.md:10: $ pub run mojom:init -p `pwd`/packages pub run mojom:generate
5 years, 8 months ago (2015-04-24 23:28:33 UTC) #4
blundell
5 years, 4 months ago (2015-08-03 16:02:35 UTC) #5 
On 2015/04/24 23:28:33, Ivan Posva wrote:
> https://codereview.chromium.org/1052993014/diff/1/mojo/dart/mojom/README.md
> File mojo/dart/mojom/README.md (right):
> 
>
https://codereview.chromium.org/1052993014/diff/1/mojo/dart/mojom/README.md#n...
> mojo/dart/mojom/README.md:10: $ pub run mojom:init -p `pwd`/packages
> pub run mojom:generate

Can this be closed?

Powered by Google App Engine
This is Rietveld 408576698