Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052993012: [Local NTP] Fix fast icon NTP height. (Closed)

Created:
5 years, 8 months ago by huangs
Modified:
5 years, 8 months ago
Reviewers:
beaudoin, fserb
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Local NTP] Fix fast icon NTP height. Committed: https://crrev.com/bbdebb0895502603da6c874b4483a26de89e0e28 Cr-Commit-Position: refs/heads/master@{#326874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/local_ntp/local_ntp_fast.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
huangs
PTAL.
5 years, 8 months ago (2015-04-24 18:55:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993012/1
5 years, 8 months ago (2015-04-24 18:56:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 19:48:34 UTC) #6
fserb
lgtm
5 years, 8 months ago (2015-04-24 20:36:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993012/1
5 years, 8 months ago (2015-04-24 20:36:41 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-24 20:36:44 UTC) #11
huangs
5 years, 8 months ago (2015-04-24 20:59:32 UTC) #13
beaudoin
LGTM
5 years, 8 months ago (2015-04-24 21:00:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993012/1
5 years, 8 months ago (2015-04-24 21:01:07 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 21:04:51 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:06:42 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bbdebb0895502603da6c874b4483a26de89e0e28
Cr-Commit-Position: refs/heads/master@{#326874}

Powered by Google App Engine
This is Rietveld 408576698