Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052993010: Adds method ordinal off-by-one error detection testing to ValidationTest. (Closed)

Created:
5 years, 8 months ago by rudominer
Modified:
5 years, 8 months ago
Reviewers:
yzshen1, viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds method ordinal off-by-one error detection testing to ValidationTest. R=viettrungluu@chromium.org, viettrungluu BUG=471803 Committed: https://chromium.googlesource.com/external/mojo/+/cd7272180af3c269dc3fbf680cbd4799395b7182

Patch Set 1 #

Patch Set 2 : Missed some files. #

Patch Set 3 : Fixed up comments. #

Total comments: 2

Patch Set 4 : foo #

Patch Set 5 : Fix comment #

Patch Set 6 : Rebased. #

Messages

Total messages: 8 (2 generated)
rudominer
5 years, 8 months ago (2015-04-03 21:01:54 UTC) #2
viettrungluu
LGTM, but do you also need to add this test for other languages?
5 years, 8 months ago (2015-04-06 17:05:15 UTC) #3
yzshen1
https://codereview.chromium.org/1052993010/diff/30001/mojo/public/cpp/bindings/tests/validation_unittest.cc File mojo/public/cpp/bindings/tests/validation_unittest.cc (right): https://codereview.chromium.org/1052993010/diff/30001/mojo/public/cpp/bindings/tests/validation_unittest.cc#newcode397 mojo/public/cpp/bindings/tests/validation_unittest.cc:397: // Any changes to the In complete comment.
5 years, 8 months ago (2015-04-06 18:41:22 UTC) #5
rudominer
On 2015/04/06 17:05:15, viettrungluu wrote: > LGTM, but do you also need to add this ...
5 years, 8 months ago (2015-04-10 18:11:05 UTC) #6
rudominer
Committed patchset #6 (id:90001) manually as cd7272180af3c269dc3fbf680cbd4799395b7182 (presubmit successful).
5 years, 8 months ago (2015-04-10 18:11:47 UTC) #7
rudominer
5 years, 8 months ago (2015-04-10 18:13:17 UTC) #8
Message was sent while issue was closed. 
done

https://codereview.chromium.org/1052993010/diff/30001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/validation_unittest.cc (right):

https://codereview.chromium.org/1052993010/diff/30001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/validation_unittest.cc:397: // Any changes to the
On 2015/04/06 18:41:22, yzshen1 wrote:
> In complete comment.

Done.

Powered by Google App Engine
This is Rietveld 408576698