Source/web/tests/WebViewTest.cpp - Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebViewTest.cpp

Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Port comment over Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebViewTest.cpp

diff --git a/Source/web/tests/WebViewTest.cpp b/Source/web/tests/WebViewTest.cpp

index 6fdc756c6e15722f85ae5053fd9ed6cc1b749837..e85d8995e77af248971ff30092d6cce456512378 100644

--- a/Source/web/tests/WebViewTest.cpp

+++ b/Source/web/tests/WebViewTest.cpp

@@ -304,6 +304,9 @@ TEST_F(WebViewTest, SetBaseBackgroundColor)

EXPECT_EQ(kTransparent, webView->backgroundColor());

LocalFrame* frame = webView->mainFrameImpl()->frame();

+ // This is a hack to prevent createView() from violating invariants about

+ // frame state during navigation/detach.

+ frame->document()->prepareForDestruction();

// Creating a new frame view with the background color having 0 alpha.

frame->createView(IntSize(1024, 768), Color::transparent, true);