Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: Source/web/tests/FrameTestHelpers.h

Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Port comment over Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/FrameTestHelpers.h
diff --git a/Source/web/tests/FrameTestHelpers.h b/Source/web/tests/FrameTestHelpers.h
index d16f987d13b5ef252e1c25603b0e81c2adedb0e5..8d876d7d3d25881f60bdf9dd8fb69500462cb7fc 100644
--- a/Source/web/tests/FrameTestHelpers.h
+++ b/Source/web/tests/FrameTestHelpers.h
@@ -114,12 +114,20 @@ private:
// frames and need further specialization of WebFrameClient behavior should subclass this.
class TestWebRemoteFrameClient : public WebRemoteFrameClient {
public:
- // Notifies the embedder that a postMessage was issued to a remote frame.
- virtual void postMessageEvent(
+ TestWebRemoteFrameClient();
+
+ WebRemoteFrame* frame() const { return m_frame; }
+
+ // WebRemoteFrameClient overrides:
+ void frameDetached() override;
+ void postMessageEvent(
WebLocalFrame* sourceFrame,
WebRemoteFrame* targetFrame,
WebSecurityOrigin targetOrigin,
- WebDOMMessageEvent) { }
+ WebDOMMessageEvent) override { }
+
+private:
+ WebRemoteFrame* const m_frame;
};
class TestWebViewClient : public WebViewClient {

Powered by Google App Engine
This is Rietveld 408576698