Source/core/frame/FrameView.cpp - Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Port comment over Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index f5d4082393cae191dd61d5318bf2e6e714832457..76e177576543c6ba919294f8d31fe5aea269f1de 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -186,6 +186,8 @@ void FrameView::dispose()

if (m_didScrollTimer.isActive())

m_didScrollTimer.stop();

+ // TODO(dcheng): Figure out why the dispose() method is virtual, and why it needs to

+ // call removeFromAXObjectCache() again.

removeFromAXObjectCache();

// Custom scrollbars should already be destroyed at this point