Source/web/tests/PinchViewportTest.cpp - Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 1052993006: Refactor frame navigation/detach state cleanup to be more sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Consolidate ScriptForbiddenScope Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index bdda29f434c3b1a0a5a681d81ccf81430bcc19a3..efaf9b35f36f56573ce191d9e5720c1b12914e1c 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -1547,6 +1547,9 @@ TEST_F(PinchViewportTest, TestMainFrameInitializationSizing)

navigateTo(m_baseURL + "content-width-1000-min-scale.html");

WebLocalFrameImpl* localFrame = webViewImpl()->mainFrameImpl();

+ // This is a hack to prevent createFrameView() from violating invariants

+ // about frame state during navigation/detach.

+ localFrame->frame()->document()->prepareForDestruction();

localFrame->createFrameView();

FrameView& frameView = *localFrame->frameView();