Refactor frame navigation/detach state cleanup to be more sane.

Source/web/tests/PinchViewportTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/frame/PinchViewport.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/FrameHost.h"
@@ skipping 1529 matching lines @@
 TEST_F(PinchViewportTest, TestMainFrameInitializationSizing)
 {
     initializeWithAndroidSettings();
 
     webViewImpl()->resize(IntSize(100, 200));
 
     registerMockedHttpURLLoad("content-width-1000-min-scale.html");
     navigateTo(m_baseURL + "content-width-1000-min-scale.html");
 
     WebLocalFrameImpl* localFrame = webViewImpl()->mainFrameImpl();
+    // This is a hack to prevent createFrameView() from violating invariants
+    // about frame state during navigation/detach.
+    localFrame->frame()->document()->prepareForDestruction();

[dcheng, 2015/04/03 14:35:45]

I couldn't think of a good way to adapt this test without having to understand
frame detach/navigation internals. So I just hacked around it for now. I plan on
revisiting this later.

     localFrame->createFrameView();
 
     FrameView& frameView = *localFrame->frameView();
     EXPECT_SIZE_EQ(IntSize(200, 400), frameView.frameRect().size());
 }
 
 // Tests that the maximum scroll offset of the viewport can be fractional.
 TEST_F(PinchViewportTest, FractionalMaxScrollOffset)
 {
     initializeWithDesktopSettings();
@@ skipping 106 matching lines @@
     EXPECT_FLOAT_POINT_EQ(FloatPoint(81, 100.8), pinchViewport.rootFrameToViewport(FloatPoint(50.5, 62.4)));
 
 
     // Scrolling the main frame should have no effect.
     frameView.scrollTo(DoublePoint(100, 120));
     EXPECT_FLOAT_POINT_EQ(FloatPoint(50, 62), pinchViewport.viewportToRootFrame(FloatPoint(80, 100)));
     EXPECT_FLOAT_POINT_EQ(FloatPoint(80, 100), pinchViewport.rootFrameToViewport(FloatPoint(50, 62)));
 }
 
 } // namespace