Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1052993005: Slim down set of things updated by roll script (Closed)

Created:
5 years, 8 months ago by jamesr
Modified:
5 years, 8 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Slim down set of things updated by roll script This reduces the list of directories updated from chromium down to be only //base, //build, //sandbox/linux and //mojo/public and their dependencies. Other directories can be updated as needed. Follow up patches will strip out parts of these components that aren't needed for Mojo development. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08be059366e24ed99c4b1af2f5702f7019330a06

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -203 lines) Patch
M mojo/tools/roll/update_from_chromium.py View 1 1 chunk +27 lines, -51 lines 0 comments Download
D tools/json_comment_eater/everything.json View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/json_comment_eater/everything_expected.json View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/json_comment_eater/json_comment_eater.py View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/json_comment_eater/json_comment_eater_test.py View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/msan/blacklist.txt View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
LGTM, AFAICT
5 years, 8 months ago (2015-04-02 21:54:48 UTC) #1
jamesr
5 years, 8 months ago (2015-04-03 18:25:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
08be059366e24ed99c4b1af2f5702f7019330a06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698