Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: media/midi/midi_manager_usb.cc

Issue 1052983002: Web MIDI: add MidiScheduler for send() with timestamp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: final Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_usb.h ('k') | media/midi/midi_manager_usb_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_usb.cc
diff --git a/media/midi/midi_manager_usb.cc b/media/midi/midi_manager_usb.cc
index eab41dae8efe5bc14b3fb55f55ce90b3047d735e..2571727cb5545891df5c77371b744da5ad10d3b0 100644
--- a/media/midi/midi_manager_usb.cc
+++ b/media/midi/midi_manager_usb.cc
@@ -9,6 +9,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
+#include "media/midi/midi_scheduler.h"
#include "media/midi/usb_midi_descriptor_parser.h"
#include "media/midi/usb_midi_device.h"
#include "media/midi/usb_midi_input_stream.h"
@@ -32,6 +33,7 @@ void MidiManagerUsb::StartInitialization() {
void MidiManagerUsb::Initialize(
base::Callback<void(MidiResult result)> callback) {
initialize_callback_ = callback;
+ scheduler_.reset(new MidiScheduler);
// This is safe because EnumerateDevices cancels the operation on destruction.
device_factory_->EnumerateDevices(
this,
@@ -48,8 +50,13 @@ void MidiManagerUsb::DispatchSendMidiData(MidiManagerClient* client,
// in the valid range.
return;
}
- output_streams_[port_index]->Send(data);
- client->AccumulateMidiBytesSent(data.size());
+ // output_streams_[port_index] is alive unless MidiManagerUsb is deleted.
+ // The task posted to the MidiScheduler will be disposed safely on deleting
+ // the scheduler.
+ scheduler_->PostSendDataTask(
+ client, data.size(), timestamp,
+ base::Bind(&UsbMidiOutputStream::Send,
+ base::Unretained(output_streams_[port_index]), data));
}
void MidiManagerUsb::ReceiveUsbMidiData(UsbMidiDevice* device,
« no previous file with comments | « media/midi/midi_manager_usb.h ('k') | media/midi/midi_manager_usb_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698