Stop SpriteView animation when window is miniaturized.

A comment in the SpriteView source states that the animation
should not run when the window is minimized, nor in the middle
of a minimize animation; it refers to http://crbug.com/350329
as the bug related to fixing this problem. However, although the
SpriteView registers for the NSWindowWillMiniaturizeNotification it
doesn't check for its occurrence, and so does not actually recognize
when a window is being minimized. As a result, the SpriteView's
animation continues running when its window is miniaturized.

This change adds a check for NSWindowWillMiniaturizeNotification and
stops the animation when caught. This change also adds a unit test to
confirm that the animation stops on window miniaturization.

My SpinnerView class was based on SpriteView, which is how I
discovered this bug. The fix and unit test both come from SpinnerView.

BUG=472836
Committed: https://crrev.com/7f9a9aac8a45e36e4b8d1621b9b50ffca91cf38b
Cr-Commit-Position: refs/heads/master@{#323963}

[shrike, 2015-04-02 19:19:21]

shrike@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2015-04-02 21:25:52]

andresantoso@chromium.org changed reviewers:
+ andresantoso@chromium.org

[Andre, 2015-04-02 21:25:52]

https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
File chrome/browser/ui/cocoa/sprite_view.mm (right):

https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
chrome/browser/ui/cocoa/sprite_view.mm:76: if ([self window] && ![[self window]
isMiniaturized] &&
This checks if the window is miniaturized. I think the problem is that when
NSWindowWillMiniaturize is invoked, -isMiniaturized is not yet YES.

[shrike, 2015-04-02 21:41:59]

On 2015/04/02 21:25:52, Andre wrote:
> This checks if the window is miniaturized. I think the problem is that when
> NSWindowWillMiniaturize is invoked, -isMiniaturized is not yet YES.

Yes, I believe that's the case.

[shrike, 2015-04-02 22:00:44]

I was waiting for the Mac trybots before asking for review but they seem to be
very backed up (I'll make sure to hear from them before committing), so...

PTAL.

[Robert Sesek, 2015-04-03 20:38:25]

LGTM

[shrike, 2015-04-06 21:14:08]

On 2015/04/02 21:25:52, Andre wrote:
>
https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
> File chrome/browser/ui/cocoa/sprite_view.mm (right):
> 
>
https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
> chrome/browser/ui/cocoa/sprite_view.mm:76: if ([self window] && ![[self
window]
> isMiniaturized] &&
> This checks if the window is miniaturized. I think the problem is that when
> NSWindowWillMiniaturize is invoked, -isMiniaturized is not yet YES.

Hi andresantoso, did you have any feedback on this cl, or does it lgty?

[Andre, 2015-04-06 21:29:59]

On 2015/04/06 21:14:08, shrike wrote:
> On 2015/04/02 21:25:52, Andre wrote:
> >
>
https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
> > File chrome/browser/ui/cocoa/sprite_view.mm (right):
> > 
> >
>
https://codereview.chromium.org/1052973004/diff/1/chrome/browser/ui/cocoa/spr...
> > chrome/browser/ui/cocoa/sprite_view.mm:76: if ([self window] && ![[self
> window]
> > isMiniaturized] &&
> > This checks if the window is miniaturized. I think the problem is that when
> > NSWindowWillMiniaturize is invoked, -isMiniaturized is not yet YES.
> 
> Hi andresantoso, did you have any feedback on this cl, or does it lgty?

LGTM

[shrike, 2015-04-06 21:34:02]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-04-06 21:34:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052973004/1

[commit-bot: I haz the power, 2015-04-06 22:29:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-06 22:30:17]

Patchset 1 (id:??) landed as
https://crrev.com/7f9a9aac8a45e36e4b8d1621b9b50ffca91cf38b
Cr-Commit-Position: refs/heads/master@{#323963}