Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1052973002: bindings: Supports {,DoNot}ExposeJSAccessors. (Closed)

Created:
5 years, 8 months ago by Yuki
Modified:
5 years, 8 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Supports {,DoNot}ExposeJSAccessors. Adds a mechanism to move DOM attributes to prototype chains or back to own properties interface-by-interface and/or attribute-by-attribute. Supported syntax and examples are demonstrated in: TestInterfaceAccessors.idl TestInterfaceOwnProperties.idl BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193039

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -45 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_overall.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 2 2 chunks +22 lines, -3 lines 0 comments Download
A Source/bindings/tests/idls/core/TestInterfaceAccessors.idl View 1 chunk +13 lines, -0 lines 0 comments Download
A Source/bindings/tests/idls/core/TestInterfaceOwnProperties.idl View 1 chunk +13 lines, -0 lines 0 comments Download
A Source/bindings/tests/idls/core/TestInterfaceOwnPropertiesDerived.idl View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + Source/bindings/tests/results/core/V8TestInterfaceAccessors.h View 2 chunks +11 lines, -10 lines 0 comments Download
A Source/bindings/tests/results/core/V8TestInterfaceAccessors.cpp View 1 chunk +188 lines, -0 lines 0 comments Download
A + Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.h View 2 chunks +11 lines, -10 lines 0 comments Download
A Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp View 1 chunk +187 lines, -0 lines 0 comments Download
A + Source/bindings/tests/results/core/V8TestInterfaceOwnPropertiesDerived.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
A Source/bindings/tests/results/core/V8TestInterfaceOwnPropertiesDerived.cpp View 1 1 chunk +187 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 7 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuki
Could you review this CL?
5 years, 8 months ago (2015-04-02 10:46:57 UTC) #2
haraken
LGTM Please just manually confirm that these IDL attributes work as expected (e.g., add [ExposeJSAccessors] ...
5 years, 8 months ago (2015-04-02 10:57:04 UTC) #3
haraken
Just a follow up for other people: We want to introduce these IDL attributes so ...
5 years, 8 months ago (2015-04-02 10:59:18 UTC) #4
Yuki
https://codereview.chromium.org/1052973002/diff/20001/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/1052973002/diff/20001/Source/bindings/scripts/v8_attributes.py#newcode503 Source/bindings/scripts/v8_attributes.py:503: raise Exception('Both of ExposeJSAccessors and DoNotExposeJSAccessors are specific at ...
5 years, 8 months ago (2015-04-02 12:03:35 UTC) #5
Jens Widell
LGTM
5 years, 8 months ago (2015-04-02 12:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052973002/40001
5 years, 8 months ago (2015-04-02 12:23:13 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 14:39:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193039

Powered by Google App Engine
This is Rietveld 408576698