Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1052963004: [cleanup] delete dead code leftover from 48eff34 (Closed)

Created:
5 years, 8 months ago by caitp (gmail)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] delete dead code leftover from 48eff34 Few pieces leftover which are now effectively dead code and can be safely deleted. BUG=v8:3502 LOG=N R=arv@chromium.org Committed: https://crrev.com/e0681f0b839bdd471c0ef2349c636ba1d98d358d Cr-Commit-Position: refs/heads/master@{#27759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +0 lines, -18 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
caitp (gmail)
PTAL --- I'd like to get this in before fixing the layout tests broken by ...
5 years, 8 months ago (2015-04-10 04:58:48 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-10 18:10:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052963004/1
5 years, 8 months ago (2015-04-10 18:10:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 18:36:08 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 18:36:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0681f0b839bdd471c0ef2349c636ba1d98d358d
Cr-Commit-Position: refs/heads/master@{#27759}

Powered by Google App Engine
This is Rietveld 408576698