Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 1052963002: Add a test for subclass maps. (Closed)

Created:
5 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a test for subclass maps. R=arv@chromium.org Committed: https://crrev.com/3c5218f6fa3b44a95c9bd0b36bf4b9e344d9939e Cr-Commit-Position: refs/heads/master@{#27812}

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A test/mjsunit/harmony/classes-maps.js View 1 2 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dmitry Lomov (no reviews)
ptal, just realized this was lying around on my machine, never committed.
5 years, 8 months ago (2015-04-02 09:45:07 UTC) #1
arv (Not doing code reviews)
https://codereview.chromium.org/1052963002/diff/1/test/mjsunit/harmony/classes-maps.js File test/mjsunit/harmony/classes-maps.js (right): https://codereview.chromium.org/1052963002/diff/1/test/mjsunit/harmony/classes-maps.js#newcode45 test/mjsunit/harmony/classes-maps.js:45: assertThrows(function() { this.byteLength; }, TypeError); wrong `this` so you ...
5 years, 8 months ago (2015-04-02 13:02:32 UTC) #2
Dmitry Lomov (no reviews)
ptal https://codereview.chromium.org/1052963002/diff/1/test/mjsunit/harmony/classes-maps.js File test/mjsunit/harmony/classes-maps.js (right): https://codereview.chromium.org/1052963002/diff/1/test/mjsunit/harmony/classes-maps.js#newcode45 test/mjsunit/harmony/classes-maps.js:45: assertThrows(function() { this.byteLength; }, TypeError); On 2015/04/02 13:02:32, ...
5 years, 8 months ago (2015-04-13 09:50:40 UTC) #3
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1052963002/diff/20001/test/mjsunit/harmony/classes-maps.js File test/mjsunit/harmony/classes-maps.js (right): https://codereview.chromium.org/1052963002/diff/20001/test/mjsunit/harmony/classes-maps.js#newcode48 test/mjsunit/harmony/classes-maps.js:48: } nit: } catch (e) {
5 years, 8 months ago (2015-04-13 15:59:39 UTC) #4
Dmitry Lomov (no reviews)
https://codereview.chromium.org/1052963002/diff/20001/test/mjsunit/harmony/classes-maps.js File test/mjsunit/harmony/classes-maps.js (right): https://codereview.chromium.org/1052963002/diff/20001/test/mjsunit/harmony/classes-maps.js#newcode48 test/mjsunit/harmony/classes-maps.js:48: } On 2015/04/13 15:59:39, arv wrote: > nit: > ...
5 years, 8 months ago (2015-04-14 09:34:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052963002/40001
5 years, 8 months ago (2015-04-14 09:34:33 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-14 09:59:12 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 09:59:22 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c5218f6fa3b44a95c9bd0b36bf4b9e344d9939e
Cr-Commit-Position: refs/heads/master@{#27812}

Powered by Google App Engine
This is Rietveld 408576698