Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1052943003: Add missing license headers for some cctests. (Closed)

Created:
5 years, 8 months ago by Paweł Hajdan Jr.
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing license headers for some cctests. BUG=chromium:98597 LOG=N Committed: https://crrev.com/260ab451708815a648384277b17cb5226d677024 Cr-Commit-Position: refs/heads/master@{#27590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M test/cctest/test-constantpool.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Paweł Hajdan Jr.
5 years, 8 months ago (2015-04-02 14:18:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm you could consider adding a checklicense step to v8
5 years, 8 months ago (2015-04-02 14:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052943003/1
5 years, 8 months ago (2015-04-02 14:20:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1713)
5 years, 8 months ago (2015-04-02 14:27:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052943003/1
5 years, 8 months ago (2015-04-02 14:30:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 14:45:49 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 14:45:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/260ab451708815a648384277b17cb5226d677024
Cr-Commit-Position: refs/heads/master@{#27590}

Powered by Google App Engine
This is Rietveld 408576698