Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105293002: Move more file_util functions to base namespace. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
jam
CC:
chromium-reviews, vandebo (ex-Chrome), weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, tzik, alecflett, amit, dcheng, rginda+watch_chromium.org, dgrogan, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, cmumford, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, nhiroki, rmsousa+watch_chromium.org, oshima+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, jsbell, Lei Zhang, tfarina, garykac+watch_chromium.org, tommycli, lambroslambrou+watch_chromium.org, Greg Billock, alexeypa+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move more file_util functions to base namespace. This moves DevicePathToDriveLetterPath, NormalizeToNativeFilePath, IsLink, and GetFileInfo. This also removes some explicit "base::" usage in base files I touched. TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238763

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -330 lines) Patch
M base/file_util.h View 1 chunk +12 lines, -13 lines 0 comments Download
M base/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 2 3 3 chunks +46 lines, -46 lines 0 comments Download
M base/file_util_unittest.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M base/file_util_win.cc View 1 2 5 chunks +113 lines, -113 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_win.cc View 1 6 chunks +14 lines, -15 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 11 chunks +20 lines, -22 lines 0 comments Download
M base/sys_info_chromeos.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_finder_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/resource_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_loader_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/duplicate_tree_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_data_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_file_element_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dragged_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webfileutilities_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years ago (2013-12-04 19:16:49 UTC) #1
brettw
7 years ago (2013-12-04 20:56:56 UTC) #2
Message was sent while issue was closed. 
Committed patchset #4 manually as r238763.

Powered by Google App Engine
This is Rietveld 408576698