Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4709)

Unified Diff: Source/platform/graphics/GraphicsContext.h

Issue 1052873003: Explicitly use SkPaint(s) in SVGShapePainter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/GraphicsContext.h
diff --git a/Source/platform/graphics/GraphicsContext.h b/Source/platform/graphics/GraphicsContext.h
index d6eb4cd4f40d45b61c3b210ae07d4e08dbf5c50a..dbcdf7b280bbcba1eb3bc208daec3af015a8f2ee 100644
--- a/Source/platform/graphics/GraphicsContext.h
+++ b/Source/platform/graphics/GraphicsContext.h
@@ -196,13 +196,13 @@ public:
void fillPolygon(size_t numPoints, const FloatPoint*, const Color&, bool shouldAntialias);
- void fillPath(const Path&);
- void strokePath(const Path&);
+ void fillPath(const Path&, const SkPaint* = nullptr);
fs 2015/04/02 15:01:47 This is a bit ugly, and only really to avoid addin
f(malita) 2015/04/02 15:23:00 Since the stroke/fill trait is specified on the Sk
fs 2015/04/07 12:03:56 Using the suggestion below.
+ void strokePath(const Path&, const SkPaint* = nullptr);
- void fillEllipse(const FloatRect&);
- void strokeEllipse(const FloatRect&);
+ void fillEllipse(const FloatRect&, const SkPaint* = nullptr);
+ void strokeEllipse(const FloatRect&, const SkPaint* = nullptr);
- void fillRect(const FloatRect&);
+ void fillRect(const FloatRect&, const SkPaint* = nullptr);
void fillRect(const FloatRect&, const Color&, SkXfermode::Mode = SkXfermode::kSrcOver_Mode);
void fillRoundedRect(const FloatRect&, const FloatSize& topLeft, const FloatSize& topRight, const FloatSize& bottomLeft, const FloatSize& bottomRight, const Color&);
void fillRoundedRect(const FloatRoundedRect&, const Color&);
@@ -211,6 +211,7 @@ public:
void strokeRect(const FloatRect&);
void strokeRect(const FloatRect&, float lineWidth);
+ void strokeRect(const FloatRect&, const SkPaint&);
f(malita) 2015/04/02 15:31:57 Same comment for fill/strokeRect -> drawRect fill
void fillBetweenRoundedRects(const FloatRect&, const FloatSize& outerTopLeft, const FloatSize& outerTopRight, const FloatSize& outerBottomLeft, const FloatSize& outerBottomRight,
const FloatRect&, const FloatSize& innerTopLeft, const FloatSize& innerTopRight, const FloatSize& innerBottomLeft, const FloatSize& innerBottomRight, const Color&);

Powered by Google App Engine
This is Rietveld 408576698