src/PNaClTranslator.cpp - Issue 1052833003: First attempt to capture parser/translation errors in browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.cpp

Issue 1052833003: First attempt to capture parser/translation errors in browser. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits and syntax errors. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.cpp

diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp

index ce462396537e1990410eae780ab88bf4289e49db..42a207b510bafb456cdf9b3f1351aa22afc68a74 100644

--- a/src/PNaClTranslator.cpp

+++ b/src/PNaClTranslator.cpp

@@ -488,7 +488,7 @@ bool TopLevelParser::ErrorAt(naclbitc::ErrorLevel Level, uint64_t Bit,

Ice::GlobalContext *Context = Translator.getContext();

{ // Lock while printing out error message.

Ice::OstreamLocker L(Context);

- raw_ostream &OldErrStream = setErrStream(Context->getStrDump());

+ raw_ostream &OldErrStream = setErrStream(Context->getStrError());

NaClBitcodeParser::ErrorAt(Level, Bit, Message);

setErrStream(OldErrStream);

}

« no previous file with comments | « src/IceGlobalContext.cpp ('k') | unittest/BitcodeMunge.cpp » ('j') | no next file with comments »