win: make CrashpadInfo retrievable

snapshot/win/pe_image_reader.h

Index: snapshot/win/pe_image_reader.h
diff --git a/snapshot/win/pe_image_reader.h b/snapshot/win/pe_image_reader.h
new file mode 100644
index 0000000000000000000000000000000000000000..0b749e8cad898d51c18896438d67c6e87e1a8fc0
--- /dev/null
+++ b/snapshot/win/pe_image_reader.h
@@ -0,0 +1,100 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_SNAPSHOT_WIN_PE_IMAGE_READER_H_
+#define CRASHPAD_SNAPSHOT_WIN_PE_IMAGE_READER_H_
+
+#include <windows.h>
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"

[Mark Mentovai, 2015/04/29 19:37:15]

Unused

[scottmg, 2015/04/30 03:31:32]

Done.

+#include "util/misc/initialization_state_dcheck.h"
+#include "util/misc/uuid.h"

[Mark Mentovai, 2015/04/29 19:37:15]

Unused (for now)

[scottmg, 2015/04/30 03:31:32]

Done.

+#include "util/stdlib/pointer_container.h"

[Mark Mentovai, 2015/04/29 19:37:15]

Unused

[scottmg, 2015/04/30 03:31:32]

Done.

+
+namespace crashpad {
+
+class ProcessReaderWin;
+
+namespace process_types {
+
+// TODO(scottmg): Genericize and/or? move process_types out of mac/.
+struct CrashpadInfo {
+  uint32_t signature;
+  uint32_t size;
+  uint32_t version;
+  uint8_t crashpad_handler_behavior;  // TriState.
+  uint8_t system_crash_reporter_forwarding;  // TriState.
+  uint16_t padding_0;
+  uint64_t simple_annotations;  // TODO(scottmg): x86/64.
+};
+
+struct Section {
+};
+
+}  // namespace process_types
+
+//! \brief A reader for PE images mapped into another process.
+//!
+//! This class is capable of reading both 32-bit and 64-bit images based on the
+//! bitness of the remote process.
+//!
+//! \sa PEImageAnnotationsReader
+class PEImageReader {
+ public:
+  PEImageReader();
+  ~PEImageReader();
+
+  //! \brief Initializes the reader.
+  //!
+  //! This method must be called only once on an object. This method must be
+  //! called successfully before any other method in this class may be called.
+  //!
+  //! \param[in] process_reader The reader for the remote process.
+  //! \param[in] address The address, in the remote process' address space,
+  //!     where the `IMAGE_DOS_HEADER` is located.
+  //! \param[in] name The module's name, a string to be used in logged messages.
+  //!     This string is for diagnostic purposes.
+  //!
+  //! \return `true` if the image was read successfully, including all load

[Mark Mentovai, 2015/04/29 19:37:15]

Load commands are a Mach-O thing. You can say what makes sense for PE or omit it
if it’s mostly obvious.

[scottmg, 2015/04/30 03:31:32]

Oops, missed that one. Done.

+  //!     commands. `false` otherwise, with an appropriate message logged.
+  bool Initialize(ProcessReaderWin* process_reader,
+                  uintptr_t address,
+                  const std::string& name);

[Mark Mentovai, 2015/04/29 19:37:15]

The member variable is module_name_ and it’s totally the same as this, so rename
this to match so that it’s easier to see where it winds up.

[scottmg, 2015/04/30 03:31:32]

Done.

+
+  //! \brief Obtains the module's CrashpadInfo structure.
+  //!
+  //! \return `true` on success, `false` on failure. If the module does not have
+  //!     a `CPADinfo` section, this will return `false` without logging any
+  //!     messages. Other failures will result in messages being logged.
+  bool GetCrashpadInfo(process_types::CrashpadInfo* crashpad_info) const;
+
+ private:
+  //! \brief Finds a given section by name in the image.
+  bool GetSectionByName(const std::string& name,
+                        IMAGE_SECTION_HEADER* section) const;
+
+  ProcessReaderWin* process_reader_;  // weak
+  uintptr_t address_;
+  std::string module_name_;
+  InitializationStateDcheck initialized_;
+
+  DISALLOW_COPY_AND_ASSIGN(PEImageReader);
+};
+
+}  // namespace crashpad
+
+#endif  // CRASHPAD_SNAPSHOT_WIN_PE_IMAGE_READER_H_