win: make CrashpadInfo retrievable

snapshot/win/module_snapshot_win.cc

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "snapshot/win/module_snapshot_win.h"
+
+#include "base/strings/stringprintf.h"
+#include "base/strings/utf_string_conversions.h"
+#include "snapshot/win/pe_image_reader.h"
+#include "util/misc/tri_state.h"
+#include "util/misc/uuid.h"
+#include "util/stdlib/strnlen.h"
+
+namespace crashpad {
+namespace internal {
+
+ModuleSnapshotWin::ModuleSnapshotWin()
+    : ModuleSnapshot(),
+      name_(),
+      timestamp_(0),
+      process_reader_(nullptr),
+      initialized_() {
+}
+
+ModuleSnapshotWin::~ModuleSnapshotWin() {
+}
+
+bool ModuleSnapshotWin::Initialize(
+    ProcessReaderWin* process_reader,
+    const ProcessInfo::Module& process_reader_module) {
+  INITIALIZATION_STATE_SET_INITIALIZING(initialized_);
+
+  process_reader_ = process_reader;
+  name_ = base::UTF16ToUTF8(process_reader_module.name);
+  timestamp_ = process_reader_module.timestamp;
+  pe_image_reader_.reset(new PEImageReader());
+  pe_image_reader_->Initialize(

[Mark Mentovai, 2015/04/29 19:37:14]

Check return value? The callee can’t fail as currently written, but as long as
it’s got a bool return value, it might change to  be able to fail in the future.

[scottmg, 2015/04/30 03:31:31]

Done.

+      process_reader_, process_reader_module.dll_base, name_);
+
+  INITIALIZATION_STATE_SET_VALID(initialized_);
+  return true;
+}
+
+void ModuleSnapshotWin::GetCrashpadOptions(CrashpadInfoClientOptions* options) {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+
+  process_types::CrashpadInfo crashpad_info;
+  if (!pe_image_reader_->GetCrashpadInfo(&crashpad_info)) {
+    options->crashpad_handler_behavior = TriState::kUnset;
+    options->system_crash_reporter_forwarding = TriState::kUnset;

[Mark Mentovai, 2015/04/29 19:37:14]

Does this make sense on Windows at all? I wasn’t sure, but if it doesn’t, we
should #if everything related to it out.

[scottmg, 2015/04/30 03:31:31]

I'm not sure if it's a good idea (I haven't actually even looked at if we can
implement the current behaviour exactly) but I was thinking we might want to
pass data to
https://msdn.microsoft.com/en-us/library/windows/desktop/bb513635(v=vs.85).aspx
.

[Mark Mentovai, 2015/04/30 20:58:35]

That’s reasonable. If we find that this doesn’t make sense on Windows at all
once we have more up and running, we can take it out later.

+    return;
+  }
+
+  options->crashpad_handler_behavior =
+      CrashpadInfoClientOptions::TriStateFromCrashpadInfo(
+          crashpad_info.crashpad_handler_behavior);
+
+  options->system_crash_reporter_forwarding =
+      CrashpadInfoClientOptions::TriStateFromCrashpadInfo(
+          crashpad_info.system_crash_reporter_forwarding);
+}
+
+std::string ModuleSnapshotWin::Name() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  return name_;
+}
+
+uint64_t ModuleSnapshotWin::Address() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";

[Mark Mentovai, 2015/04/29 19:37:14]

Makes it easier to review, too. :)

[scottmg, 2015/04/30 03:31:31]

Hopefully future reviews will be a bit "harder". :)

[Mark Mentovai, 2015/04/30 20:58:35]

scottmg wrote:
:)

+  return 0;
+}
+
+uint64_t ModuleSnapshotWin::Size() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+  return 0;
+}
+
+time_t ModuleSnapshotWin::Timestamp() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  return timestamp_;
+}
+
+void ModuleSnapshotWin::FileVersion(uint16_t* version_0,
+                                    uint16_t* version_1,
+                                    uint16_t* version_2,
+                                    uint16_t* version_3) const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+}
+
+void ModuleSnapshotWin::SourceVersion(uint16_t* version_0,
+                                      uint16_t* version_1,
+                                      uint16_t* version_2,
+                                      uint16_t* version_3) const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+}
+
+ModuleSnapshot::ModuleType ModuleSnapshotWin::GetModuleType() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+  return ModuleSnapshot::ModuleType();
+}
+
+void ModuleSnapshotWin::UUID(crashpad::UUID* uuid) const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+}
+
+std::vector<std::string> ModuleSnapshotWin::AnnotationsVector() const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+  return std::vector<std::string>();
+}
+
+std::map<std::string, std::string> ModuleSnapshotWin::AnnotationsSimpleMap()
+    const {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  CHECK(false) << "TODO(scottmg)";
+  return std::map<std::string, std::string>();
+}
+
+}  // namespace internal
+}  // namespace crashpad