Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: net/http/http_stream_factory_impl_job.cc

Issue 1052743003: Move RC4 behind a fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: agl comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_stream_factory_impl_job.h" 5 #include "net/http/http_stream_factory_impl_job.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1274 fallback = FALLBACK_TLS1; 1274 fallback = FALLBACK_TLS1;
1275 break; 1275 break;
1276 case SSL_PROTOCOL_VERSION_TLS1_1: 1276 case SSL_PROTOCOL_VERSION_TLS1_1:
1277 fallback = FALLBACK_TLS1_1; 1277 fallback = FALLBACK_TLS1_1;
1278 break; 1278 break;
1279 } 1279 }
1280 } 1280 }
1281 UMA_HISTOGRAM_ENUMERATION("Net.ConnectionUsedSSLVersionFallback", 1281 UMA_HISTOGRAM_ENUMERATION("Net.ConnectionUsedSSLVersionFallback",
1282 fallback, FALLBACK_MAX); 1282 fallback, FALLBACK_MAX);
1283 1283
1284 UMA_HISTOGRAM_BOOLEAN("Net.ConnectionUsedSSLDeprecatedCipherFallback",
1285 ssl_config->enable_deprecated_cipher_suites);
1286
1284 // We also wish to measure the amount of fallback connections for a host that 1287 // We also wish to measure the amount of fallback connections for a host that
1285 // we know implements TLS up to 1.2. Ideally there would be no fallback here 1288 // we know implements TLS up to 1.2. Ideally there would be no fallback here
1286 // but high numbers of SSLv3 would suggest that SSLv3 fallback is being 1289 // but high numbers of SSLv3 would suggest that SSLv3 fallback is being
1287 // caused by network middleware rather than buggy HTTPS servers. 1290 // caused by network middleware rather than buggy HTTPS servers.
1288 const std::string& host = server.host(); 1291 const std::string& host = server.host();
1289 if (!is_proxy && 1292 if (!is_proxy &&
1290 host.size() >= 10 && 1293 host.size() >= 10 &&
1291 host.compare(host.size() - 10, 10, "google.com") == 0 && 1294 host.compare(host.size() - 10, 10, "google.com") == 0 &&
1292 (host.size() == 10 || host[host.size()-11] == '.')) { 1295 (host.size() == 10 || host[host.size()-11] == '.')) {
1293 UMA_HISTOGRAM_ENUMERATION("Net.GoogleConnectionUsedSSLVersionFallback", 1296 UMA_HISTOGRAM_ENUMERATION("Net.GoogleConnectionUsedSSLVersionFallback",
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
1468 1471
1469 if (job_status_ == STATUS_SUCCEEDED && other_job_status_ == STATUS_BROKEN) { 1472 if (job_status_ == STATUS_SUCCEEDED && other_job_status_ == STATUS_BROKEN) {
1470 HistogramBrokenAlternateProtocolLocation( 1473 HistogramBrokenAlternateProtocolLocation(
1471 BROKEN_ALTERNATE_PROTOCOL_LOCATION_HTTP_STREAM_FACTORY_IMPL_JOB_MAIN); 1474 BROKEN_ALTERNATE_PROTOCOL_LOCATION_HTTP_STREAM_FACTORY_IMPL_JOB_MAIN);
1472 session_->http_server_properties()->MarkAlternativeServiceBroken( 1475 session_->http_server_properties()->MarkAlternativeServiceBroken(
1473 other_job_alternative_service_); 1476 other_job_alternative_service_);
1474 } 1477 }
1475 } 1478 }
1476 1479
1477 } // namespace net 1480 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698