Decouple TabLoader from SessionRestore.

Decouple TabLoader from SessionRestore by introducing SessionRestoreDelegate.

SessionRestore will call SessionRestoreDelegate::RestoreTabs once, which in turn will call TabLoader::RestoreTabs.

Note:
- This is step 2 in refactoring the session restore code (see CL 1042863006).

BUG=

Committed: https://crrev.com/a3ae61c719f620a9d1aa217b07e4099d44e53765
Cr-Commit-Position: refs/heads/master@{#323384}

[Georges Khalil, 2015-04-01 19:09:38]

Patchset #2 (id:20001) has been deleted

[Georges Khalil, 2015-04-01 19:10:06]

Patchset #1 (id:1) has been deleted

[Georges Khalil, 2015-04-01 19:24:36]

Patchset #1 (id:40001) has been deleted

[Georges Khalil, 2015-04-01 19:30:55]

georgesak@chromium.org changed reviewers:
+ sky@chromium.org

[Georges Khalil, 2015-04-01 19:30:55]

PTAL.

[sky, 2015-04-01 22:41:46]

LGTM

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore_delegate.h (right):

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/session_restore_delegate.h:27: };
private:
DISALLOW_IMPLICIT_CONSTRUCTORS.

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/tab_loader.cc (right):

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/tab_loader.cc:184: for (int i = 0; i <
static_cast<int>(tabs.size()); i++) {
Don't static cast like this. Easiest way is to use new loop, eg:

for (auto& restore_tab : tabs) {
  ..
}

[Georges Khalil, 2015-04-01 23:17:03]

Patchset #2 (id:80001) has been deleted

[Georges Khalil, 2015-04-01 23:28:08]

Patchset #2 (id:100001) has been deleted

[Georges Khalil, 2015-04-01 23:30:21]

PTAnL as the first change listed below is not trivial.

- Remove inheritance between TabLoader and SessionRestoreDelegate. This was
discussed early one but it's relevance is not clear anymore and its removal is
necessary to add DISALLOW_IMPLICIT_CONSTRUCTORS.
- Replace all typedef with new syntax (using) to match new definition
(RestoredTab).
- Remove static_cast and use new for loop, as per comment.

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore_delegate.h (right):

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/session_restore_delegate.h:27: };
On 2015/04/01 22:41:46, sky wrote:
> private:
> DISALLOW_IMPLICIT_CONSTRUCTORS.

Done.

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/tab_loader.cc (right):

https://codereview.chromium.org/1052733002/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/tab_loader.cc:184: for (int i = 0; i <
static_cast<int>(tabs.size()); i++) {
On 2015/04/01 22:41:46, sky wrote:
> Don't static cast like this. Easiest way is to use new loop, eg:
> 
> for (auto& restore_tab : tabs) {
>   ..
> }

Done.

https://codereview.chromium.org/1052733002/diff/110001/chrome/browser/session...
File chrome/browser/sessions/tab_loader.h (right):

https://codereview.chromium.org/1052733002/diff/110001/chrome/browser/session...
chrome/browser/sessions/tab_loader.h:40: using RestoredTab =
SessionRestoreDelegate::RestoredTab;
Necessary up here because of RestoreTabs function.

https://codereview.chromium.org/1052733002/diff/110001/chrome/browser/session...
chrome/browser/sessions/tab_loader.h:60: using RenderWidgetHostSet =
std::set<content::RenderWidgetHost*>;
Changed to new syntax to match RestoredTab.

[sky, 2015-04-01 23:31:58]

LGTM

[Georges Khalil, 2015-04-01 23:52:02]

The CQ bit was checked by georgesak@chromium.org

[commit-bot: I haz the power, 2015-04-01 23:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052733002/110001

[commit-bot: I haz the power, 2015-04-02 01:04:33]

Committed patchset #2 (id:110001)

[commit-bot: I haz the power, 2015-04-03 20:20:39]

Patchset 2 (id:??) landed as
https://crrev.com/a3ae61c719f620a9d1aa217b07e4099d44e53765
Cr-Commit-Position: refs/heads/master@{#323384}