Source/core/animation/ElementAnimation.h - Issue 105273010: Web Animations API: Start implementation of timing input objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimation.h

Issue 105273010: Web Animations API: Start implementation of timing input objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change isnan to std:isnan Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/web-animations-api/element-animate-list-of-keyframes.html ('k') | Source/core/animation/ElementAnimation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ElementAnimation.h

diff --git a/Source/core/animation/ElementAnimation.h b/Source/core/animation/ElementAnimation.h

index 6818a24de0a358aebe66f24fa5195b12c8c975ca..20ba3d025929a497a3cc7d477a251f0b92e32468 100644

--- a/Source/core/animation/ElementAnimation.h

+++ b/Source/core/animation/ElementAnimation.h

@@ -31,22 +31,27 @@

#ifndef ElementAnimation_h

#define ElementAnimation_h

-#include "CSSPropertyNames.h" // For CSSPropertyID.

+#include "core/css/parser/BisonCSSParser.h"

namespace WebCore {

class Animation;

class Dictionary;

class Element;

+struct Timing;

class ElementAnimation {

public:

static CSSPropertyID camelCaseCSSPropertyNameToID(const String& propertyName);

- static Animation* animate(Element*, Vector<Dictionary> keyframesDictionaryVector, double duration = 0);

+ static Animation* animate(Element*, Vector<Dictionary> keyframesDictionaryVector, Dictionary timingInput);

+ static Animation* animate(Element*, Vector<Dictionary> keyframesDictionaryVector, double timingInput);

+ static Animation* animate(Element*, Vector<Dictionary> keyframesDictionaryVector);

private:

- static Animation* startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector, double duration = 0);

+ static Animation* startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector, Dictionary timingInput);

+ static Animation* startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector, double timingInput);

+ static Animation* startAnimation(Element*, Vector<Dictionary> keyframesDictionaryVector);

+ static void populateTiming(Timing&, Dictionary);

friend class AnimationElementAnimationTest;

};