Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: LayoutTests/web-animations-api/element-animate-list-of-keyframes.html

Issue 105273010: Web Animations API: Start implementation of timing input objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change treatment of invalid duration input Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/bindings.gypi » ('j') | Source/bindings/v8/custom/V8ElementCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/web-animations-api/element-animate-list-of-keyframes.html
diff --git a/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html b/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html
index 6d5009cc96d7aadf4390ff98291133297126a60d..7af653277c95d2b429d04f4b04ef9e4a36c4aad3 100644
--- a/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html
+++ b/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html
@@ -27,14 +27,14 @@ var e1Style = getComputedStyle(e1);
var e2Style = getComputedStyle(e2);
var e3Style = getComputedStyle(e3);
-var duration = 1;
+var durationValue = 1;
test(function() {
e1.animate([
{left: '10px', opacity: '1', offset: 0},
{left: '100px', opacity: '0', offset: 1}
- ], duration);
- internals.pauseAnimations(duration / 2);
+ ], durationValue);
+ internals.pauseAnimations(durationValue / 2);
assert_equals(e1Style.left, '55px');
assert_equals(e1Style.opacity, '0.5');
}, 'Calling animate() should start an animation.');
@@ -43,8 +43,8 @@ test(function() {
e2.animate([
{backgroundColor: 'green', offset: 0},
{backgroundColor: 'purple', offset: 1}
- ], duration);
- internals.pauseAnimations(duration / 2);
+ ], durationValue);
+ internals.pauseAnimations(durationValue / 2);
assert_equals(e2Style.backgroundColor, 'rgb(64, 64, 64)');
}, 'Calling animate() should start an animation. CamelCase property names should be parsed.');
@@ -55,8 +55,8 @@ var keyframesWithInvalid = [
];
test(function() {
- e3.animate(keyframesWithInvalid, duration);
- internals.pauseAnimations(duration);
+ e3.animate(keyframesWithInvalid, {duration: durationValue, fill: 'forwards'});
+ internals.pauseAnimations(durationValue);
assert_equals(e3Style.width, '1000px');
assert_equals(e3Style.backgroundColor, 'rgb(0, 0, 0)');
assert_equals(e3Style.foo, undefined);
« no previous file with comments | « no previous file | Source/bindings/bindings.gypi » ('j') | Source/bindings/v8/custom/V8ElementCustom.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698