Source/core/animation/ElementAnimation.idl - Issue 105273010: Web Animations API: Start implementation of timing input objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimation.idl

Issue 105273010: Web Animations API: Start implementation of timing input objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add custom binding for timing input and handle each case separately. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/ElementAnimation.cpp ('K') | « Source/core/animation/ElementAnimation.cpp ('k') | Source/core/animation/ElementAnimationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ElementAnimation.idl

diff --git a/Source/core/animation/ElementAnimation.idl b/Source/core/animation/ElementAnimation.idl

index e191d950bc02e025aac90ab22382d9a37232258a..e8bfe6228c9accd77d4553b03d9a686143ebf3f9 100644

--- a/Source/core/animation/ElementAnimation.idl

+++ b/Source/core/animation/ElementAnimation.idl

@@ -29,5 +29,5 @@

partial interface Element {

- [RuntimeEnabled=WebAnimationsAPI] void animate(sequence<Dictionary> keyframes, optional double duration);

+ [Custom, RuntimeEnabled=WebAnimationsAPI] void animate(sequence<Dictionary> keyframes, optional any timingInput);

dstockwell 2014/01/21 20:47:29 If we put back the two overloads and mark both Cus

rjwright 2014/01/22 03:56:08 No. It doesn't compile. It seems to ignore the cus

};

« Source/core/animation/ElementAnimation.cpp ('K') | « Source/core/animation/ElementAnimation.cpp ('k') | Source/core/animation/ElementAnimationTest.cpp » ('j') | no next file with comments »