Web Animations API: Start implementation of timing input objects.

Source/bindings/v8/custom/V8ElementCustom.cpp

+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "V8Element.h"
+
+#include "V8Animation.h"
+#include "bindings/v8/Dictionary.h"
+#include "core/animation/ElementAnimation.h"
+
+namespace WebCore {
+void V8Element::animateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

[haraken, 2014/01/23 02:37:57]

Are you writing this method in custom bindings just because the overload
resolution algorithm is not correctly implemented in the current IDL compiler?

What's the difference between the auto-generated code and this custom binding
code?

I want to understand why you need to write this in custom bindings.

+{
+    Element* imp = V8Element::toNative(info.Holder());
+
+    if (info.Length() == 1 && info[0]->IsArray()) {
+        V8TRYCATCH_VOID(Vector<Dictionary>, keyframes, toNativeArray<Dictionary>(info[0], 1, info.GetIsolate()));
+        v8SetReturnValueFast(info, ElementAnimation::animate(imp, keyframes), imp);
+        return;
+    }
+
+    if (info.Length() == 2 && info[0]->IsArray()) {
+        V8TRYCATCH_VOID(Vector<Dictionary>, keyframes, toNativeArray<Dictionary>(info[0], 1, info.GetIsolate()));
+
+        if (info[1]->IsObject()) {
+            V8TRYCATCH_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate()));
+            v8SetReturnValueFast(info, ElementAnimation::animate(imp, keyframes, timingInput), imp);
+            return;
+        }
+
+        V8TRYCATCH_VOID(double, timingInput, info[1]->NumberValue());
+        v8SetReturnValueFast(info, ElementAnimation::animate(imp, keyframes, timingInput), imp);
+        return;
+    }
+
+    ExceptionState exceptionState(ExceptionState::ExecutionContext, "animate", "Element", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < 1)) {
+        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    exceptionState.throwTypeError("No function was found that matched the signature provided.");
+    exceptionState.throwIfNeeded();
+}
+
+} // namespace WebCore