NaCl: create a separate namespace for Mojo handles.

shell/native_application_support.cc

Index: shell/native_application_support.cc
diff --git a/shell/native_application_support.cc b/shell/native_application_support.cc
index 49754b439edd818ad993c2fee7c9debad8182b3f..74993c253a2ec36912cf7a802b756969a61f34d1 100644
--- a/shell/native_application_support.cc
+++ b/shell/native_application_support.cc
@@ -14,6 +14,7 @@
 #include "mojo/public/platform/native/gles2_impl_occlusion_query_ext_thunks.h"
 #include "mojo/public/platform/native/gles2_impl_thunks.h"
 #include "mojo/public/platform/native/gles2_thunks.h"
+#include "mojo/public/platform/native/system_impl_private_thunks.h"
 #include "mojo/public/platform/native/system_thunks.h"
 
 namespace mojo {
@@ -66,6 +67,12 @@ bool RunNativeApplication(base::NativeLibrary app_library,
     return false;
   }
 
+  // TODO(ncbray): enforce the private nature of this API, somehow?
+  SetThunks(&MojoMakeSystemImplThunksPrivate, "MojoSetSystemImplThunksPrivate",

[Nick Bray (chromium), 2015/04/06 22:51:00]

I hate these names, but  coming up with names for two similar but distinct
interfaces is difficult.  Thoughts?

[viettrungluu, 2015/04/06 23:21:02]

(I asked this elsewhere....) Do you really need two thunk tables?

[viettrungluu, 2015/04/06 23:49:33]

Also, if you really need two thunk tables (and I understand the appeal), I'd
call the first one "SystemImplControlThunks" and the latter "SystemImplThunks".
Maybe you can think of a better word than "control".

[Nick Bray (chromium), 2015/04/07 23:51:06]

Used the naming scheme you suggested.

No "need" strictly speaking, but it would make it simpler to evolve interfaces
in the future.

+            app_library);
+  SetThunks(&MojoMakeExplicitSystemThunksPrivate,
+            "MojoSetExplicitSystemThunksPrivate", app_library);
+
   if (SetThunks(&MojoMakeGLES2ControlThunks, "MojoSetGLES2ControlThunks",
                 app_library)) {
     // If we have the control thunks, we should also have the GLES2