Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: nacl_bindings_generator/generate_nacl_bindings.py

Issue 1052723003: NaCl: create a separate namespace for Mojo handles. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Edits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/platform/native/system_impl_private_thunks.h ('K') | « nacl_bindings/mojo_syscall.cc ('k') | nacl_bindings_generator/mojo_syscall.cc.tmpl » ('j') | nacl_bindings_generator/mojo_syscall.cc.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: nacl_bindings_generator/generate_nacl_bindings.py
diff --git a/nacl_bindings_generator/generate_nacl_bindings.py b/nacl_bindings_generator/generate_nacl_bindings.py
index d3748232f78e4764b6108e1dc8b9daa9c62c50df..ce5dc79503e6c926d6758e04edd8e12f4171e055 100755
--- a/nacl_bindings_generator/generate_nacl_bindings.py
+++ b/nacl_bindings_generator/generate_nacl_bindings.py
@@ -366,7 +366,12 @@ def GenerateMojoSyscall(functions, common_vars, out):
# Call
getParams = [impl.CallParam() for impl in impls[:-1]]
- code << 'result_value = %s(%s);' % (f.name, ', '.join(getParams))
+ callTarget = f.name
+ # Redirect to namespaced functions.
+ if callTarget.startswith("Mojo"):
+ callTarget = callTarget[:4] + 'SystemImpl' + callTarget[4:]
+ getParams = ['g_mojo_system'] + getParams
+ code << 'result_value = %s(%s);' % (callTarget, ', '.join(getParams))
code << ''
# Write outputs
« mojo/public/platform/native/system_impl_private_thunks.h ('K') | « nacl_bindings/mojo_syscall.cc ('k') | nacl_bindings_generator/mojo_syscall.cc.tmpl » ('j') | nacl_bindings_generator/mojo_syscall.cc.tmpl » ('J')

Powered by Google App Engine
This is Rietveld 408576698