nacl_bindings_generator/generate_nacl_bindings.py - Issue 1052723003: NaCl: create a separate namespace for Mojo handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: nacl_bindings_generator/generate_nacl_bindings.py

Issue 1052723003: NaCl: create a separate namespace for Mojo handles. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Tweak Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: nacl_bindings_generator/generate_nacl_bindings.py

diff --git a/nacl_bindings_generator/generate_nacl_bindings.py b/nacl_bindings_generator/generate_nacl_bindings.py

index d3748232f78e4764b6108e1dc8b9daa9c62c50df..ce5dc79503e6c926d6758e04edd8e12f4171e055 100755

--- a/nacl_bindings_generator/generate_nacl_bindings.py

+++ b/nacl_bindings_generator/generate_nacl_bindings.py

@@ -366,7 +366,12 @@ def GenerateMojoSyscall(functions, common_vars, out):

# Call

getParams = [impl.CallParam() for impl in impls[:-1]]

- code << 'result_value = %s(%s);' % (f.name, ', '.join(getParams))

+ callTarget = f.name

+ # Redirect to namespaced functions.

+ if callTarget.startswith("Mojo"):

+ callTarget = callTarget[:4] + 'SystemImpl' + callTarget[4:]

+ getParams = ['g_mojo_system'] + getParams

+ code << 'result_value = %s(%s);' % (callTarget, ', '.join(getParams))

code << ''

# Write outputs

« no previous file with comments | « nacl_bindings/mojo_syscall.cc ('k') | nacl_bindings_generator/mojo_syscall.cc.tmpl » ('j') | no next file with comments »