Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1052713002: Revert of Add CHECKs when updating pointers from the slots and store buffers (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add CHECKs when updating pointers from the slots and store buffers (patchset #3 id:40001 of https://codereview.chromium.org/1035763002/) Reason for revert: Got one dev-channel with this. Should be enough. Original issue's description: > Add CHECKs when updating pointers from the slots and store buffers > > We want to verify that we always overwrite heap objects with heap > objects, and non-heap objects with non-heap objects > > BUG=chromium:452095 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 > Cr-Commit-Position: refs/heads/master@{#27479} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452095 Committed: https://crrev.com/43394806197eacb80afd642d4e373c3faaa637be Cr-Commit-Position: refs/heads/master@{#27565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 5 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Add CHECKs when updating pointers from the slots and store buffers
5 years, 8 months ago (2015-04-01 14:35:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052713002/1
5 years, 8 months ago (2015-04-01 14:35:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 14:35:41 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 14:35:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43394806197eacb80afd642d4e373c3faaa637be
Cr-Commit-Position: refs/heads/master@{#27565}

Powered by Google App Engine
This is Rietveld 408576698