Issue 1052693004: move => bind this workaround to js_ast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052693004: move => bind this workaround to js_ast (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

move => bind this workaround to js_ast cleaner since we only worry about it in one place, and the "this" check is easier and more precise now. incidentally, I saw a CL go by on the V8 bug, looks like it's close to being fixed R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/96032dc8ddef638cd04910de5d6b34fb4236b933

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -176 lines)			Patch
M	lib/runtime/dart/_internal.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/runtime/dart/_isolate_helper.js	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	1	48 chunks	+207 lines, -107 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/runtime/dart/core.js	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/runtime/dart/isolate.js	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View		8 chunks	+4 lines, -43 lines	0 comments	Download
M	lib/src/js/nodes.dart	View	1	2 chunks	+22 lines, -1 line	0 comments	Download
M	lib/src/js/printer.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jennifer Messerly

5 years, 8 months ago (2015-04-02 19:17:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
96032dc8ddef638cd04910de5d6b34fb4236b933 (presubmit successful).