Issue 1052693003: Revert API change from issue 1053883002.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052693003: Revert API change from issue 1053883002. (Closed)

Created:
5 years, 8 months ago by tonyg

Modified:
5 years, 8 months ago

Reviewers:
hansmuller, hansmuller1

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert API change from issue 1053883002. tl;dr is that unless the Proxy is passed, the caller doesn't know whether it's a Stub or Proxy (or whether it's bound). See that patch for further explanation. BUG= R=hansmuller@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7228f73b52d6fd7a290c3c4b3aef38f9ed98154b

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sky/framework/embedder.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

tonyg

5 years, 8 months ago (2015-04-02 15:38:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7228f73b52d6fd7a290c3c4b3aef38f9ed98154b (presubmit successful).