Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1052693002: Add some layout tests for Notification.data on persistent notifications (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
Reviewers:
johnme
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add some layout tests for Notification.data on persistent notifications These tests verify that our serialization behavior matches what we expect to get. The implementation-imposed limit is also being tested. BUG=442129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194031

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 1 2 2 chunks +12 lines, -1 line 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-data-invalid.html View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Beverloo
I don't intend to test SerializedScriptValue - are you OK with just having these two ...
5 years, 8 months ago (2015-04-01 13:58:26 UTC) #2
johnme
sounds reasonable; lgtm with comment https://codereview.chromium.org/1052693002/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html File LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html (right): https://codereview.chromium.org/1052693002/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html#newcode31 LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html:31: { property: 'foobar', Since ...
5 years, 8 months ago (2015-04-08 18:27:51 UTC) #3
Peter Beverloo
https://codereview.chromium.org/1052693002/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html File LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html (right): https://codereview.chromium.org/1052693002/diff/1/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html#newcode31 LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html:31: { property: 'foobar', On 2015/04/08 18:27:51, johnme wrote: > ...
5 years, 8 months ago (2015-04-20 11:29:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052693002/40001
5 years, 8 months ago (2015-04-20 11:29:47 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:40:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194031

Powered by Google App Engine
This is Rietveld 408576698