Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

Issue 1052673002: Expose kDeviceLoginScreenDomainAutoComplete through CrosSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
index 824f61522f81f8db3eb7bd2e66136f3906c50234..5451f0d1fae7f3ebfc930befc47fc300364164f1 100644
--- a/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
+++ b/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
@@ -142,6 +142,26 @@ class DeviceSettingsProviderTest : public DeviceSettingsTestBase {
&expected_frequency_value));
}
+ // Helper routine to set LoginScreenDomainAutoComplete policy.
+ void SetDomainAutoComplete(const std::string& domain) {
+ EXPECT_CALL(*this, SettingChanged(_)).Times(AtLeast(1));
+ em::LoginScreenDomainAutoCompleteProto* proto =
+ device_policy_.payload().mutable_login_screen_domain_auto_complete();
+ proto->set_login_screen_domain_auto_complete(domain);
+ device_policy_.Build();
+ device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
+ ReloadDeviceSettings();
+ Mock::VerifyAndClearExpectations(this);
+ }
+
+ // Helper routine to check value of the LoginScreenDomainAutoComplete policy.
+ void VerifyDomainAutoComplete(
+ const base::StringValue* const ptr_to_expected_value) {
+ EXPECT_TRUE(base::Value::Equals(
+ provider_->Get(kAccountsPrefLoginScreenDomainAutoComplete),
+ ptr_to_expected_value));
+ }
+
ScopedTestingLocalState local_state_;
scoped_ptr<DeviceSettingsProvider> provider_;
@@ -445,4 +465,19 @@ TEST_F(DeviceSettingsProviderTest, DecodeHeartbeatSettings) {
VerifyHeartbeatSettings(false, heartbeat_frequency);
}
+TEST_F(DeviceSettingsProviderTest, DecodeDomainAutoComplete) {
+ // By default LoginScreenDomainAutoComplete policy should not be set.
+ VerifyDomainAutoComplete(nullptr);
+
+ // Empty string means that the policy is not set.
+ SetDomainAutoComplete("");
+ VerifyDomainAutoComplete(nullptr);
+
+ // Check some meaningful value. Policy should be set.
+ const std::string domain = "domain.test";
+ const base::StringValue domain_value(domain);
+ SetDomainAutoComplete(domain);
+ VerifyDomainAutoComplete(&domain_value);
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698