Expose kDeviceLoginScreenDomainAutoComplete through CrosSettings

chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_policy_decoder_chromeos.h"
 
 #include <limits>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 577 matching lines @@
 
     if (container.has_login_screen_default_virtual_keyboard_enabled()) {
       policies->Set(
           key::kDeviceLoginScreenDefaultVirtualKeyboardEnabled,
           POLICY_LEVEL_MANDATORY,
           POLICY_SCOPE_MACHINE,
           new base::FundamentalValue(
               container.login_screen_default_virtual_keyboard_enabled()),
           NULL);
     }
-
-    // The behavior when policy is not set and when it is set to an empty string
-    // is the same. Thus lets add policy to the map only if it is set and its
-    // value is not an empty string.

[Mattias Nissler (ping if slow), 2015/04/02 08:29:38]

The rule is to show whatever is present in policy as accurately as possible in
chrome://policy. Thus, no cleverness required, please make the code dumb.

[peletskyi, 2015/04/07 12:06:29]

Done.

-    if (container.has_login_screen_domain_auto_complete() &&
-        !container.login_screen_domain_auto_complete().empty()) {
-      policies->Set(
-          key::kDeviceLoginScreenDomainAutoComplete, POLICY_LEVEL_MANDATORY,
-          POLICY_SCOPE_MACHINE,
-          new base::StringValue(container.login_screen_domain_auto_complete()),
-          nullptr);
-    }

[Mattias Nissler (ping if slow), 2015/04/02 08:29:38]

This block should stay, so the policy gets displayed correctly on
chrome://policy

[peletskyi, 2015/04/07 12:06:29]

Done.

   }
 }
 
 void DecodeGenericPolicies(const em::ChromeDeviceSettingsProto& policy,
                            PolicyMap* policies) {
   if (policy.has_device_policy_refresh_rate()) {
     const em::DevicePolicyRefreshRateProto& container(
         policy.device_policy_refresh_rate());
     if (container.has_device_policy_refresh_rate()) {
       policies->Set(
@@ skipping 162 matching lines @@
   // Decode the various groups of policies.
   DecodeLoginPolicies(policy, policies);
   DecodeNetworkPolicies(policy, policies);
   DecodeReportingPolicies(policy, policies);
   DecodeAutoUpdatePolicies(policy, policies);
   DecodeAccessibilityPolicies(policy, policies);
   DecodeGenericPolicies(policy, policies);
 }
 
 }  // namespace policy