Expose kDeviceLoginScreenDomainAutoComplete through CrosSettings

chrome/browser/chromeos/settings/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/logging.h"
@@ skipping 64 matching lines @@
     kStartUpFlags,
     kStatsReportingPref,
     kSystemTimezonePolicy,
     kSystemUse24HourClock,
     kUpdateDisabled,
     kVariationsRestrictParameter,
     kDeviceDisabled,
     kDeviceDisabledMessage,
     kRebootOnShutdown,
     kExtensionCacheSize,
+    kDeviceLoginScreenDomainAutoComplete,
 };
 
 bool HasOldMetricsFile() {
   // TODO(pastarmovj): Remove this once migration is not needed anymore.
   // If the value is not set we should try to migrate legacy consent file.
   // Loading consent file state causes us to do blocking IO on UI thread.
   // Temporarily allow it until we fix http://crbug.com/62626
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   return GoogleUpdateSettings::GetCollectStatsConsent();
 }
@@ skipping 322 matching lines @@
   } else {
     new_values_cache->SetBoolean(kAttestationForContentProtectionEnabled, true);
   }
 
   if (policy.has_extension_cache_size() &&
       policy.extension_cache_size().has_extension_cache_size()) {
     new_values_cache->SetInteger(
         kExtensionCacheSize,
         policy.extension_cache_size().extension_cache_size());
   }
+
+  // The behavior when policy is not set and when it is set to an empty string
+  // is the same. Thus lets add policy only if it is set and its value is not
+  // an empty string.
+  if (policy.has_login_screen_domain_auto_complete() &&
+      policy.has_login_screen_domain_auto_complete()

[Andrew T Wilson (Slow), 2015/04/01 13:33:21]

This doesn't look like it compiles. I wonder if we should change the attribute
names so they aren't identical, because this is hard to read.

[peletskyi, 2015/04/01 13:55:19]

I've fixed this. About names - I just follow the common pattern in
chrome_device_policy.proto

+          .has_login_screen_domain_auto_complete() &&
+      !policy.login_screen_domain_auto_complete().empty()) {
+    new_values_cache->SetString(kDeviceLoginScreenDomainAutoComplete,
+                                policy.login_screen_domain_auto_complete()
+                                    .login_screen_domain_auto_complete());
+  }
 }
 
 void DecodeDeviceState(const em::PolicyData& policy_data,
                        PrefValueMap* new_values_cache) {
   if (!policy_data.has_device_state())
     return;
 
   const em::DeviceState& device_state = policy_data.device_state();
 
   if (device_state.device_mode() == em::DeviceState::DEVICE_MODE_DISABLED)
@@ skipping 367 matching lines @@
 void DeviceSettingsProvider::AttemptMigration() {
   if (device_settings_service_->HasPrivateOwnerKey()) {
     PrefValueMap::const_iterator i;
     for (i = migration_values_.begin(); i != migration_values_.end(); ++i)
       DoSet(i->first, *i->second);
     migration_values_.Clear();
   }
 }
 
 }  // namespace chromeos