Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052663004: Implicit constructors for SkFunction are much more readable. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implicit constructors for SkFunction are much more readable. BUG=skia: Committed: https://skia.googlesource.com/skia/+/03e5161bed3bdfa0d9fb0867378237bac7d8bd12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M src/core/SkFunction.h View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/FunctionTest.cpp View 1 chunk +16 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052663004/1
5 years, 8 months ago (2015-04-01 19:54:37 UTC) #2
mtklein_C
5 years, 8 months ago (2015-04-01 19:54:41 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-01 20:06:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052663004/1
5 years, 8 months ago (2015-04-01 20:07:32 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-01 20:07:34 UTC) #10
bungeman-skia
lgtm
5 years, 8 months ago (2015-04-01 20:08:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052663004/1
5 years, 8 months ago (2015-04-01 20:08:33 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 20:08:54 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/03e5161bed3bdfa0d9fb0867378237bac7d8bd12

Powered by Google App Engine
This is Rietveld 408576698