Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_names.dart

Issue 1052653002: Fix length computation on init.mangledNames. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/mirrors/reflect_two_classes_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/js_names.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_names.dart b/sdk/lib/_internal/compiler/js_lib/js_names.dart
index 76c72be48adabb952e2dfb909ec172076fea2319..708b873b7e5deed4e18bb17dbd499d77b1ea08fa 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_names.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_names.dart
@@ -130,7 +130,8 @@ class _LazyReflectiveNamesMap {
return result;
}
- int get _jsMangledNamesLength => JS('int', '#.length', _jsMangledNames);
+ int get _jsMangledNamesLength => JS('int', 'Object.keys(#).length',
+ _jsMangledNames);
String operator[](String key) {
if (_cache == null || _jsMangledNamesLength != _cacheLength) {
« no previous file with comments | « no previous file | tests/lib/mirrors/reflect_two_classes_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698