Issue 1052603002: Revert of AX nodes that aren't contenteditable should be readonly.

Issue 1052603002: Revert of AX nodes that aren't contenteditable should be readonly. (Closed)

Created:
5 years, 8 months ago by hayato

Modified:
5 years, 8 months ago

Reviewers:
je_julie(Not used), dmazzoni

CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@listboxes_too

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of AX nodes that aren't contenteditable should be readonly. (patchset #2 id:20001 of https://codereview.chromium.org/1039023002/) Reason for revert: Blink gardening. The following tests are failing on Win7 after this CL. DumpAccessibilityTreeTest.AccessibilityAriaColumnHeader DumpAccessibilityTreeTest.AccessibilityAriaGrid DumpAccessibilityTreeTest.AccessibilityAriaGridCell DumpAccessibilityTreeTest.AccessibilityAriaLevel DumpAccessibilityTreeTest.AccessibilityAriaOrientation DumpAccessibilityTreeTest.AccessibilityAriaRow DumpAccessibilityTreeTest.AccessibilityAriaRowGroup DumpAccessibilityTreeTest.AccessibilityAriaRowHeader DumpAccessibilityTreeTest.AccessibilityAriaSortOnAriaGrid DumpAccessibilityTreeTest.AccessibilityAriaSortOnHtmlTable DumpAccessibilityTreeTest.AccessibilityAriaTreeGrid DumpAccessibilityTreeTest.AccessibilityCaption DumpAccessibilityTreeTest.AccessibilityContenteditableDescendants DumpAccessibilityTreeTest.AccessibilityIframe DumpAccessibilityTreeTest.AccessibilityIframePresentational DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeOpened Build log: https://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/9222 Sheriff-o-matic says the blink range is 192906:192906. Original issue's description: > AX nodes that aren't contenteditable should be readonly. > > We were returning the wrong result from AXObjects that > did not descend from AXNodeObject. > > BUG=471075 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192906 TBR=je_julie.kim@samsung.com,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471075 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192915

Patch Set 1 #

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -18 lines)			Patch
M	LayoutTests/accessibility/readonly.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	LayoutTests/accessibility/readonly-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/accessibility/AXNodeObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/accessibility/AXObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/accessibility/AXObject.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hayato

Created Revert of AX nodes that aren't contenteditable should be readonly.

5 years, 8 months ago (2015-04-01 09:33:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052603002/1

5 years, 8 months ago (2015-04-01 09:34:16 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 09:35:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192915

Expand Messages | Collapse Messages