Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1052583005: Remove usage of SingleThreadTaskRunner from DataReductionProxyConfig. (Closed)

Created:
5 years, 8 months ago by jeremyim
Modified:
5 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of SingleThreadTaskRunner from DataReductionProxyConfig. With the removal using the DataReductionProxyService class to perform the secure proxy check, there is no longer a need to post tasks to the UI thread. This effectively makes DataReductionProxyConfig an IO thread only class, and does not need to have pointers to task runners. BUG=472290 Committed: https://crrev.com/c1fe98e261ba2dea61a291b3f0b4f9afa2f2ddec Cr-Commit-Position: refs/heads/master@{#327360}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Messages

Total messages: 7 (2 generated)
jeremyim
PTAL. =)
5 years, 7 months ago (2015-04-28 18:20:24 UTC) #2
bengr
lgtm. Thanks for doing this!
5 years, 7 months ago (2015-04-28 19:45:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052583005/40001
5 years, 7 months ago (2015-04-28 19:47:39 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 20:41:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 20:43:08 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c1fe98e261ba2dea61a291b3f0b4f9afa2f2ddec
Cr-Commit-Position: refs/heads/master@{#327360}

Powered by Google App Engine
This is Rietveld 408576698