Revert of Disable chromium_builder_tests entries for chromecast.

Revert of Disable chromium_builder_tests entries for chromecast. (patchset #2 id:20001 of https://codereview.chromium.org/1043233002/)

Reason for revert:
Chromecast doesn't actually need to build chromium_builder_tests, so reverting to remove the introduced complexity.

Fixed more correctly in: https://codereview.chromium.org/1049333002/ 

Original issue's description:
> Disable chromium_builder_tests entries for chromecast.
> 
> R=thakis@chromium.org
> BUG=472150
> 
> Committed: https://crrev.com/ab581451d0bd05433afeb7e953bb1fcf229915bb
> Cr-Commit-Position: refs/heads/master@{#323072}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472150

[gunsch, 2015-04-01 15:43:42]

Created Revert of Disable chromium_builder_tests entries for chromecast.

[Nico, 2015-04-01 17:55:34]

not lgtm

https://codereview.chromium.org/1049333002/ only changes the bot configs. Devs
should be able to build all targets without errors too. The thing you're
reverting here is the more correct fix,
https://codereview.chromium.org/1049333002/ is the bandaid. I'd revert this
revert.

[gunsch, 2015-04-01 17:58:19]

On 2015/04/01 17:55:34, Nico wrote:
> not lgtm
> 
> https://codereview.chromium.org/1049333002/ only changes the bot configs. Devs
> should be able to build all targets without errors too. The thing you're
> reverting here is the more correct fix,
> https://codereview.chromium.org/1049333002/ is the bandaid. I'd revert this
> revert.

Didn't submit the revert yet because I wanted to see your thoughts first.

Is the expectation then that we should be able to build 'All' with
"chromecast==1" then? If so, we'll probably need to guard *more* targets in
all.gyp: nothing from src/chrome/ should be built when chromecast==1.

[Nico, 2015-04-01 18:01:35]

On 2015/04/01 17:58:19, gunsch wrote:
> On 2015/04/01 17:55:34, Nico wrote:
> > not lgtm
> > 
> > https://codereview.chromium.org/1049333002/ only changes the bot configs.
Devs
> > should be able to build all targets without errors too. The thing you're
> > reverting here is the more correct fix,
> > https://codereview.chromium.org/1049333002/ is the bandaid. I'd revert this
> > revert.
> 
> Didn't submit the revert yet because I wanted to see your thoughts first.
> 
> Is the expectation then that we should be able to build 'All' with
> "chromecast==1" then?

Yes. Not just All, but even 'all' (the former is the 'All' target in
build/all.gypi, the latter are all the targets referenced by build/all.gypi). In
general, if a gyp setitng is toggled, everything should build with that toggle,
and all tests built when building with that toggle should pass.

> If so, we'll probably need to guard *more* targets in
> all.gyp: nothing from src/chrome/ should be built when chromecast==1.

[gunsch, 2015-04-01 18:10:34]

On 2015/04/01 18:01:35, Nico wrote:
> On 2015/04/01 17:58:19, gunsch wrote:
> > On 2015/04/01 17:55:34, Nico wrote:
> > > not lgtm
> > > 
> > > https://codereview.chromium.org/1049333002/ only changes the bot configs.
> Devs
> > > should be able to build all targets without errors too. The thing you're
> > > reverting here is the more correct fix,
> > > https://codereview.chromium.org/1049333002/ is the bandaid. I'd revert
this
> > > revert.
> > 
> > Didn't submit the revert yet because I wanted to see your thoughts first.
> > 
> > Is the expectation then that we should be able to build 'All' with
> > "chromecast==1" then?
> 
> Yes. Not just All, but even 'all' (the former is the 'All' target in
> build/all.gypi, the latter are all the targets referenced by build/all.gypi).
In
> general, if a gyp setitng is toggled, everything should build with that
toggle,
> and all tests built when building with that toggle should pass.
> 
> > If so, we'll probably need to guard *more* targets in
> > all.gyp: nothing from src/chrome/ should be built when chromecast==1.

SGTM, I'll close this and continue working on build/all.gyp.