Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 1052563002: [bindings] Include V8HiddenValue only if attribute has CachedAttribute or marked keep alive for GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 1052563002: [bindings] Include V8HiddenValue only if attribute has CachedAttribute or marked keep alive for GC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

index e47a6d0a7ba2ea6760d86f278d3d8707a28fe461..ca2da0983042aebaab29aaf697bddd151fa54b96 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -9,7 +9,6 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

-#include "bindings/core/v8/V8HiddenValue.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

#include "bindings/core/v8/V8TestInterfaceWillBeGarbageCollected.h"

#include "core/dom/ContextFeatures.h"

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »