Issue 1052553006: Remove checks in fxcrt now that FX_NEW can't return 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052553006: Remove checks in fxcrt now that FX_NEW can't return 0. (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang, Lei Zhang (Do not use)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove checks in fxcrt now that FX_NEW can't return 0. Replace them with |new| so that we can tell by the presence of FX_NEW the places that still need to be audited. R=thestig@google.com, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6c0d01b0244af7d8f9a896e626c7a7d5476a7373

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -52 lines)			Patch
M	core/include/fxcrt/fx_basic.h	View	2 chunks	+5 lines, -14 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_util.cpp	View	2 chunks	+3 lines, -12 lines	0 comments	Download
M	core/src/fxcrt/fx_xml_parser.cpp	View	4 chunks	+7 lines, -26 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, first of a bunch. I want to try small patches in case something needs ...

5 years, 8 months ago (2015-04-15 17:50:10 UTC) #1

Tom Sepez

5 years, 8 months ago (2015-04-15 21:17:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6c0d01b0244af7d8f9a896e626c7a7d5476a7373 (presubmit successful).