Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1052553004: Fix DriveApiRequestsTest.EmptyBatchUploadRequest in official builds. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DriveApiRequestsTest.EmptyBatchUploadRequest in official builds. Official builds don't include strings for CHECKs, so don't check for text. Right now, the test is failing like so when doing an official build: ..\..\google_apis\drive\drive_api_requests_unittest.cc(2000): error: Death test: request->Commit() Result: died but not with expected error. Expected: Check failed Actual msg: BUG=467929 TBR=hirono@chromium.org Committed: https://crrev.com/932a905ff8eb8462af417bd038081db2954e133d Cr-Commit-Position: refs/heads/master@{#325246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
5 years, 8 months ago (2015-04-15 15:05:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052553004/1
5 years, 8 months ago (2015-04-15 15:05:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 15:30:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/932a905ff8eb8462af417bd038081db2954e133d Cr-Commit-Position: refs/heads/master@{#325246}
5 years, 8 months ago (2015-04-15 15:31:57 UTC) #5
hirono
5 years, 8 months ago (2015-04-16 03:33:21 UTC) #6
Message was sent while issue was closed.
On 2015/04/15 15:31:57, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/932a905ff8eb8462af417bd038081db2954e133d
> Cr-Commit-Position: refs/heads/master@{#325246}

Thank you for fixing this!

Powered by Google App Engine
This is Rietveld 408576698