Issue 1052523006: Don't crash when using IME on an input field with a CSS-specified font.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052523006: Don't crash when using IME on an input field with a CSS-specified font. (Closed)

Created:
5 years, 8 months ago by Avi (use Gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't crash when using IME on an input field with a CSS-specified font. BUG=471689 TEST=repro in bug 473859 no longer crashes Committed: https://crrev.com/fcab92b0617293ba2172e86122bc2d7cb273c708 Cr-Commit-Position: refs/heads/master@{#323971}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	content/common/mac/attributed_string_coder.mm	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	content/common/mac/font_descriptor.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Mark Mentovai

LGTM. I can’t think of anything better to do than a nil check either.

5 years, 8 months ago (2015-04-06 22:25:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052523006/1

5 years, 8 months ago (2015-04-06 22:29:53 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-06 23:02:24 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fcab92b0617293ba2172e86122bc2d7cb273c708
Cr-Commit-Position: refs/heads/master@{#323971}